BIND 10 #3050: "skip" flag not cleared if no callouts are attached to a hook

[BIND 10 Development]

#3050: "skip" flag not cleared if no callouts are attached to a hook
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:
  stephen                            |                Status:  new
                       Type:         |             Milestone:  DHCP
  defect                             |  Outstanding Tasks
                   Priority:         |              Keywords:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DHCP
  Unclassified                       |  Estimated Difficulty:  0
               CVSS Scoring:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
 In the hooks system, the "skip" flag is set by a callout to indicate to
 the server that normal processing should be skipped when the callout
 returns.  When the server calls the callouts attached to a hook, this flag
 is cleared before any calls are made. The problem is that this flag is
 only cleared if callouts are actually attached to the hook.  If there are
 no callouts, the flag retains its previous value.

 The fix is trivial - in CalloutManager::callCallouts(), unconditionally
 clear the "skip" flag on entry to the method.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3050>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development