BIND 10 #3010: Fix signed integer overflow

BIND 10 Development do-not-reply at isc.org
Mon Jul 15 03:51:24 UTC 2013


#3010: Fix signed integer overflow
-------------------------------------+-------------------------------------
            Reporter:  shane         |                        Owner:  muks
                Type:  defect        |                       Status:
            Priority:  low           |  reviewing
           Component:  libdns++      |                    Milestone:
            Keywords:                |  Sprint-20130723
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  1             |              Defect Severity:  Low
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by muks):

 Hi Shane

 Here is my review:

 * The use of `uint64_t` looks good to me.
 * Why was the `seconds` variable introduced? It doesn't seem possible that
 a value would fail the newly introduced checks and pass the old checks
 below on `value` and `val`. In case there is, can you add a unittest for
 it?
 * There is a trailing whitespace in the patch.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3010#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list