BIND 10 #2994: Add selected few (3-4) hooks into DHCPv4 server
BIND 10 Development
do-not-reply at isc.org
Mon Jul 22 16:48:47 UTC 2013
#2994: Add selected few (3-4) hooks into DHCPv4 server
-------------------------------------+-------------------------------------
Reporter: tomek | Owner: tomek
Type: enhancement | Status:
Priority: medium | closed
Component: dhcp4 | Milestone:
Keywords: | Sprint-DHCP-20130731
Sensitive: 0 | Resolution: fixed
Sub-Project: DHCP | CVSS Scoring:
Estimated Difficulty: 0 | Defect Severity: N/A
Total Hours: 0 | Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by tomek):
* status: reviewing => closed
* resolution: => fixed
Comment:
Replying to [comment:7 stephen]:
> Reviewed commit 89d6be56eefa1ed79d9c0cfb8112243e1435beb6
>
> '''src/bin/dhcp4/dhcp4_hooks.dox'''[[BR]]
> subnet4_select: do you mean to say that "prefixes" will be assigned
here?
There is no prefix delegation for DHCPv4. It was a leftover from DHCPv6.
Removed.
> '''src/lib/dhcpsrv/tests/alloc_engine_unittest.cc'''[[BR]]
> I would add
> {{{
> #include <algorithm>
> }}}
> to the file to ensure that the definition of sort() is present even if
changes are made to other header files.
Added.
> These issues are minor. Please merge after you have fixed them - I
don't need to see the code again.
Thank you for your review.
Code merged, closing ticket.
--
Ticket URL: <http://bind10.isc.org/ticket/2994#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list