BIND 10 #3008: Develop NameChange{Sender,Listener} classes.

[BIND 10 Development]

#3008: Develop NameChange{Sender,Listener} classes.
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:  tmark
                Type:  enhancement   |                       Status:
            Priority:  medium        |  reviewing
           Component:  dhcp-ddns     |                    Milestone:
            Keywords:                |  Sprint-DHCP-20130731
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:  n
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by tmark):

 Replying to [comment:11 marcin]:
 > Replying to [comment:9 tmark]:
 > > Replying to [comment:8 marcin]:
 > > >
 > > >
 > > > '''src/bin/d2/ncr_udp.h'''
 >
 > > > UDPCallback::operator(): please check alignment of the second line
 of the operator declaration.
 >
 > Still not fixed.
 >
 > > >
 > > > UDPCallback::setDataSource: can UDPEndpointPtr be passed by
 reference?
 >
 > This haven't been addressed.

 Got it this time.
 >
 > > >
 > >
 > > UDPCallback changes done.
 >
 > See above.
 >
 > > >
 > > > NameChangeUDPSender::open: In the Doxygen comment the:
 > > > {{{
 > > > @throw throws a NcrUDPError if the open fails
 > > > }}}
 > > > should rather be
 > > > {{{
 > > > @throw NcrUDPError if the open fails
 > >
 > > Fixed all @throw throws in ncr_io.h and ncr_udp.h
 > >
 > > > }}}
 > > > Also, spurious space between !''IOService!'' and ampersand.
 > >
 > > got it
 >
 > It remains in the header file.

 Got it.

 >
 > > >
 > > > '''src/bin/d2/tests/ncr_udp_unittests.cc'''
 > > > checkSendVsReceived: It should be fine to compare the text form
 until we implement more proper way to compare these two. However, I would
 suggest that the operator is now created and that the text comparison is
 moved to this new operator. That way, you could be already using the
 equality operator to compre name change request. Once you finally
 implement proper comparison, it would be transparent change for the code.
 With the current code you would have to identify all places in the code
 where text comparison is made and replace it.
 > >
 > > As part of the work I am doing on the queue manager (trac 3052), I
 implemented == and !=.  I have
 > > pulled that change into 3008.
 >
 > Cool. Thanks!
 >
 > Could !ChangeLog be:
 > {{{
 > 6xx.    [func]      [tmark]
 >     Added initial implementation of classes for sending
 >     and receiving NameChangeRequests between DHCP and
 >     DDNS. This includes both abstract classes and a
 >     derivation which traffics requests across UDP sockets.
 >     (trac3008 git TBD)
 > }}}
 > ?

 I think the following eliminates the ambiguity of "DDNS":

 {{{
 6xx.    [func]      [tmark]
     Added initial implementation of classes for sending
     and receiving NameChangeRequests between DHCP-DDNS
     and its clients such as DHCP. This includes both
     abstract classes and a derivation which traffics
     requests across UDP sockets.
     (trac3008 git TBD)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/3008#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development