BIND 10 #2843: isc.statistics.counters.py shouldn't have DNS-specific information

[BIND 10 Development]

#2843: isc.statistics.counters.py shouldn't have DNS-specific information
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  defect        |  naokikambe
            Priority:  medium        |                       Status:
           Component:  statistics    |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130806
         Sub-Project:  Core          |                   Resolution:
Estimated Difficulty:  2             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => naokikambe


Comment:

 Hello

 Generally, it looks OK. I have just very minor observations.

 First one is, you seem to refer to the `__doc__` elements directly. While
 it is technically true the documentation is stored there, I thought python
 always tried to hide it little bit. Wouldn't it be better to reference to
 other docstrigs as „see documentation for isc.statistics.counters“ instead
 of „see isc.statistics.counters.__doc__“? Or, is there any reason to
 include the `__doc__` there?

 I'm little bit worried about the spec file parameter being optional. For
 one, the general description of both classes says it may be there and how
 it works if it is there, but it doesn't say what happens when the
 parameter is not present. But the bigger problem (which was, arguably, not
 introduced in this ticket) I see is that the hardcoded default is for one
 single module. Is there a reason to have this default? Wouldn't it be
 better the spec file was mandatory?

-- 
Ticket URL: <http://bind10.isc.org/ticket/2843#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development