BIND 10 #3065: Create a library for handling request messages for DHCP-DDNS

[BIND 10 Development]

#3065: Create a library for handling request messages for DHCP-DDNS
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:  tmark
                Type:  enhancement   |                       Status:
            Priority:  medium        |  reviewing
           Component:  dhcp-ddns     |                    Milestone:
            Keywords:                |  Sprint-DHCP-20130731
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:                |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tomek):

 * owner:  tomek => tmark


Comment:

 Tom told me that he code was already reviewed, so this review covers
 everything else that is not in .cc or .h files.

 This is a new library, so its purpose should be explained. This doesn't
 have to be a long essay - couple sentences will suffice for now. See
 src/lib/dhcp/libdhcp++.dox or src/lib/dhcpsrv/*.dox for examples. The idea
 is to give overview and explain the "big picture" - how the classes are
 intended to be used. No need to repeat the details that are already in the
 classes documentation. Make sure to put links to that new doc somewhere in
 doc/devel/mainpage.dox.

 The code does compile but fails link:
 {{{
 make[7]: Entering directory
 `/home/thomson/devel/bind10/src/lib/dhcp_ddns/tests'
   CXXLD  libdhcp_ddns_unittests
 libdhcp_ddns_unittests-ncr_msg.o: In function
 `isc::dhcp_ddns::NameChangeRequest::fromJSON(std::string const&)':
 /home/thomson/devel/bind10/src/lib/dhcp_ddns/tests/../ncr_msg.cc:149:
 undefined reference to `isc::data::Element::fromJSON(std::string const&)'
 collect2: error: ld returned 1 exit status
 make[7]: *** [libdhcp_ddns_unittests] Error 1
 }}}

 I have added
 {{{
 libdhcp_ddns_unittests_LDADD += $(top_builddir)/src/lib/cc/libb10-cc.la
 }}}
 to src/lib/dhcp_ddns/tests/Makefile.am and it solved the problem. Please
 pull my changes.

 There is no ChangeLog entry. Adding a new library is a change big enough
 that warrants a changelog entry.

 Otherwise the code is fine. make, make check, make distcheck runs fine.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3065#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development