BIND 10 #2964: xfrin should use general datasource configuration, not Auth/database_file
BIND 10 Development
do-not-reply at isc.org
Tue Jun 4 01:17:43 UTC 2013
#2964: xfrin should use general datasource configuration, not Auth/database_file
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: defect | jinmei
Priority: medium | Status:
Component: xfrin | accepted
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130611
Sub-Project: DNS | Resolution:
Estimated Difficulty: 5 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
trac2964 is ready for review.
There is one thing I didn't anticipate for this task, which made the
branch bigger and possibly controversial: with the generic data source
configuration, xfrin would not be able to create initial zone itself
any more (it wouldn't even know which data source it should use for
that). There can be several ways to address this issue, but I've
personally been believing such an operation should be done outside of
xfrin, so I handled it by moving this feature from xfrin. I did it by
extending b10-loadzone so it'll simply create an empty zone (it
already has an ability of creating a new zone). We can discuss this
is a valid way to address the xfrin issue, but I believe the added
ability to loadzone can be useful for other purposes in any case.
I also introduced a new helper module under the isc.server_common
package to handle a set of data source client lists. Something like
this will be necessary for all variants of this task, so it should
make sense to introduce a common module.
Except these, the changes should be quite straightforward:
- commits up to 159d0dd are initial cleanup and preparation
refactoring. Basically there shouldn't be behavior change in
effect. I think these commits are better reviewed separately.
- 43c9101 and 7a0ffbd are related to the updates to b10-loadzone.
- 1c50519 is the newly added helper class under server_common.
- the rest of the branch implements the goal of this ticket on top of
the above setup. These changes are probably easy to review as a
single diff.
Proposed changelog:
{{{
623.? [bug]* jinmei
b10-xfrin/b10-loadzone: b10-xfrin now refers to the unified
"data_sources" module configuration instead of almost-deprecated
the Auth/database_file configuration (Note: zonemgr still uses the
latter, so a secondary server would still need it for the moment).
Due to this change, b10-xfrin does not auto-generate an initial
zone for the very first transfer anymore; b10-loadzone has been
extended with a new -e option for the initial setup.
(Trac #2946, git TBD)
}}}
--
Ticket URL: <http://bind10.isc.org/ticket/2964#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list