BIND 10 #2956: DHCP-DDNS: Create server controller class

[BIND 10 Development]

#2956: DHCP-DDNS: Create server controller class
-------------------------------------+-------------------------------------
            Reporter:  stephen       |                        Owner:  tmark
                Type:  enhancement   |                       Status:
            Priority:  medium        |  reviewing
           Component:  dhcp          |                    Milestone:
            Keywords:                |  Sprint-DHCP-20130606
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => tmark


Comment:

 Reviewed commit 21f3ea90672b5bf84886e58f08f97bbcc63dfd6d

 '''src/bin/d2/Makefile.am'''[[BR]]
 Typo: s/b10-dchdp-ddns.xml/b10-dhcp-ddns.xml/

 '''src/bin/d2/b10-dhcp-ddns.xml'''[[BR]]
 Should replace all occurrences of "D2" with "DHCP-DDNS" for documentation.

 You should probably add something to say that the process is started by
 BIND 10 depending on the configuration options, and that the command-line
 arguments are for testing purposes only.

 '''src/bin/d2/d2.spec'''[[BR]]
 > Gut and paste error. Fixed.
 The rest of us have to make do with the "Cut" function.  You really are
 using an industrial-strength text editor, aren't you?

 '''src/bin/d2/d2_log.cc'''[[BR]]
 Typo: s/b10-dhpc-ddns/b10-dhcp-ddns/

 '''src/bin/d2/d_controller.cc'''[[BR]]
 In the isc_throw error messages, suggest a space after the terminating
 colon in the text string to make the error messages more readable, e.g.
 change:
 {{{
 "Application process initialization failed:" << ex.what()
 }}}
 to
 {{{
 "Application process initialization failed: " << ex.what()
 }}}
 (This occurs in several places.)


 '''src/bin/d2/d_controller.h'''[[BR]]
 >> DControllerBase::getXxxx()/isXxxx(): most of these methods can be
 declared "const".
 > Done.
 A bit over-enthusiastic in adding "const" to the return value if that
 value is a primitive type:
 {{{
 ../../../src/bin/d2/d_process.h:130:33: error: type qualifiers ignored on
 function return type [-Werror=ignored-qualifiers]
 In file included from ../../../src/bin/d2/d2_controller.h:18:0,
                  from main.cc:17:
 ../../../src/bin/d2/d_controller.h:347:31: error: type qualifiers ignored
 on function return type [-Werror=ignored-qualifiers]
 ../../../src/bin/d2/d_controller.h:361:28: error: type qualifiers ignored
 on function return type [-Werror=ignored-qualifiers]
 cc1plus: all warnings being treated as errors
 }}}

 '''!ChangeLog'''[[BR]]
 I didn't comment on the !ChangeLog last time.  It looks OK.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2956#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development