BIND 10 #2964: xfrin should use general datasource configuration, not Auth/database_file
BIND 10 Development
do-not-reply at isc.org
Thu Jun 6 19:28:05 UTC 2013
#2964: xfrin should use general datasource configuration, not Auth/database_file
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: defect | jinmei
Priority: medium | Status:
Component: xfrin | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130611
Sub-Project: DNS | Resolution:
Estimated Difficulty: 5 | CVSS Scoring:
Total Hours: 0.83 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:13 vorner]:
> > > All the wrong configs about the `DataSrcClientMgr` seem to be
violating the specs. Should there be a test with a valid spec (for example
with non-existent type of data source)?
> >
> > In practice, this case shouldn't be so different from errors like
> > nonexistent type of data source for higher level Python programs:
>
> If you know the internal implementation, then they are indeed very
similar. But they _could_ be very different, one could be eliminated much
sooner if there was some validation according to the spec file.
>
> I don't insist on it the hard way, but I believe adding such test would
be a good thing and not much work.
>
> I believe it can be merged with or without such test.
Okay, on thinking about it again, I chose not to add another test this
time. Generally, adding more tests is a good thing, but conciseness
is also important, and in this case the point of possible behavior
difference is quite far from the tested code, so I preferred the latter.
Now merge done, closing.
--
Ticket URL: <http://bind10.isc.org/ticket/2964#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list