BIND 10 #3001: BIND10-1.1.0 fails to build because of missing header inclusions

[BIND 10 Development]

#3001: BIND10-1.1.0 fails to build because of missing header inclusions
-------------------------------------+-------------------------------------
            Reporter:  thozza        |                         Type:
              Status:  new           |  defect
           Milestone:  New Tasks     |                     Priority:  high
            Keywords:                |                    Component:
           Sensitive:  0             |  Unclassified
         Sub-Project:  Core          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  High
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
 I'm unable to compile latest bind10 version 1.1.0 using Fedora rawhide.
 There seems to be missing inclusion of stdint.h header in files:

 {{{
 src/lib/util/random/qid_gen.h
 src/lib/util/memory_segment_mapped.cc
 }}}

 After I added inclusion of stdint.h into gid_gen.h, the
 problem in memory_segment_mapped.cc appeared. After fixing
 the second file BIND10 compiles just fine.

 Error in qid_gen.h
 {{{
 ...
 /bin/sh ../../../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H
 -I. -I../../..  -I../../../src/lib -I../../../src/lib
 -I../../../src/lib/util -I../../../src/lib/util
 -I../../../src/lib/exceptions -I../../../src/lib/exceptions
 -DLOCKFILE_DIR=\"/var/bind10\" -DOS_LINUX  -I../../../ext/asio
 -I../../../ext/coroutine -DASIO_DISABLE_THREADS=1 -Wall -Wextra -Wwrite-
 strings -Woverloaded-virtual -Wno-sign-compare -fPIC  -O2 -g -pipe -Wall
 -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-
 size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-
 cc1 -m64 -mtune=generic -c -o qid_gen.lo `test -f 'random/qid_gen.cc' ||
 echo './'`random/qid_gen.cc
 libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../src/lib
 -I../../../src/lib -I../../../src/lib/util -I../../../src/lib/util
 -I../../../src/lib/exceptions -I../../../src/lib/exceptions
 -DLOCKFILE_DIR=\"/var/bind10\" -DOS_LINUX -I../../../ext/asio
 -I../../../ext/coroutine -DASIO_DISABLE_THREADS=1 -Wall -Wextra -Wwrite-
 strings -Woverloaded-virtual -Wno-sign-compare -fPIC -O2 -g -pipe -Wall
 -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-
 size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-
 cc1 -m64 -mtune=generic -c random/qid_gen.cc  -fPIC -DPIC -o
 .libs/qid_gen.o
 In file included from random/qid_gen.cc:21:0:
 ../../../src/lib/util/random/qid_gen.h:58:5: error: 'uint16_t' does not
 name a type
      uint16_t generateQid();
      ^
 random/qid_gen.cc:49:1: error: 'uint16_t' does not name a type
  uint16_t
  ^
 make[5]: *** [qid_gen.lo] Error 1
 make[5]: *** Waiting for unfinished jobs....
 ...
 }}}

 Error in memory_segment_mapped.cc:
 {{{
 ...
 /bin/sh ../../../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H
 -I. -I../../..  -I../../../src/lib -I../../../src/lib
 -I../../../src/lib/util -I../../../src/lib/util
 -I../../../src/lib/exceptions -I../../../src/lib/exceptions
 -DLOCKFILE_DIR=\"/var/bind10\" -DOS_LINUX  -I../../../ext/asio
 -I../../../ext/coroutine -DASIO_DISABLE_THREADS=1 -Wall -Wextra -Wwrite-
 strings -Woverloaded-virtual -Wno-sign-compare -fPIC  -O2 -g -pipe -Wall
 -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-
 size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-
 cc1 -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -c -o
 qid_gen.lo `test -f 'random/qid_gen.cc' || echo './'`random/qid_gen.cc
 libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../src/lib
 -I../../../src/lib -I../../../src/lib/util -I../../../src/lib/util
 -I../../../src/lib/exceptions -I../../../src/lib/exceptions
 -DLOCKFILE_DIR=\"/var/bind10\" -DOS_LINUX -I../../../ext/asio
 -I../../../ext/coroutine -DASIO_DISABLE_THREADS=1 -Wall -Wextra -Wwrite-
 strings -Woverloaded-virtual -Wno-sign-compare -fPIC -O2 -g -pipe -Wall
 -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-
 size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-
 cc1 -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -c
 random/qid_gen.cc  -fPIC -DPIC -o .libs/qid_gen.o
 memory_segment_mapped.cc: In member function 'size_t
 isc::util::MemorySegmentMapped::getCheckSum() const':
 memory_segment_mapped.cc:369:11: error: 'uint8_t' does not name a type
      const uint8_t* const cp_begin = static_cast<const uint8_t*>(
            ^
 memory_segment_mapped.cc:371:11: error: 'uint8_t' does not name a type
      const uint8_t* const cp_end = cp_begin +
 impl_->base_sgmt_->get_size();
            ^
 memory_segment_mapped.cc:374:16: error: 'uint8_t' does not name a type
      for (const uint8_t* cp = cp_begin; cp < cp_end; cp += pagesize) {
                 ^
 memory_segment_mapped.cc:374:40: error: expected ';' before 'cp'
      for (const uint8_t* cp = cp_begin; cp < cp_end; cp += pagesize) {
                                         ^
 memory_segment_mapped.cc:374:40: error: 'cp' was not declared in this
 scope
 memory_segment_mapped.cc:374:45: error: 'cp_end' was not declared in this
 scope
      for (const uint8_t* cp = cp_begin; cp < cp_end; cp += pagesize) {
                                              ^
 make[5]: *** [memory_segment_mapped.lo] Error 1
 ...
 }}}

 For reference:
 [[https://lists.isc.org/pipermail/bind10-dev/2013-June/004685.html|bind10-dev
 list post]]

-- 
Ticket URL: <http://bind10.isc.org/ticket/3001>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development