BIND 10 #2726: New cppcheck reports

[BIND 10 Development]

#2726: New cppcheck reports
-------------------------------------+-------------------------------------
            Reporter:  muks          |                        Owner:
                Type:  defect        |  UnAssigned
            Priority:  medium        |                       Status:
           Component:  Unclassified  |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130625
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => UnAssigned
 * status:  accepted => reviewing


Comment:

 Hello

 It should be ready for review.

 I don't think this needs a changelog entry, since there's no functional
 nor API change.

 I tried to add `-I./ext/asio` too, but then it run for more than half of
 hour, which seems too much.

 Also, I upgraded to cppcheck 1.60.1 in between. I fixed some of what it
 reported, I think, but there are 3 groups of reports that I left unfixed,
 and I think we should create a new ticket for them:
  * Thinks like this: `src/lib/util/random/random_number_generator.h:113:
 check_fail: Assert statement calls a function which may have desired side
 effects: 'areProbabilitiesValid'. (warning,assertWithSideEffect)`. They
 are invalid, as these functions have no side effects.
  * `src/lib/dhcpsrv/tests/mysql_lease_mgr_unittest.cc:748: check_fail:
 Array 'leases[2]' accessed at index 2, which is out of bounds.
 (error,arrayIndexOutOfBounds)` ‒ this is dhcp code.
  * Unmatched suppressions ‒ it seems newer cppcheck removed some checks.
 I'm not sure what to do about these not to introduce warnings to the
 previous versions ‒ maybe suppress the warning about unmatched
 suppression.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2726#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development