BIND 10 #3005: New reports from cppcheck 1.60.1

[BIND 10 Development]

#3005: New reports from cppcheck 1.60.1
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:
  vorner                             |                Status:  new
                       Type:         |             Milestone:  New Tasks
  defect                             |              Keywords:
                   Priority:         |             Sensitive:  0
  medium                             |           Sub-Project:  DNS
                  Component:         |  Estimated Difficulty:  0
  Unclassified                       |           Total Hours:  0
               CVSS Scoring:         |
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
 As always, there are new reports with new version.

 There are three groups.

 * Reports about array bounds in DHCP code. A separate ticket #3004 was
 created for them.
 * Complains about assert, like:

 {{{
 src/lib/util/random/random_number_generator.h:113: check_fail: Assert
 statement calls a function which may have desired side effects:
 'areProbabilitiesValid'. (warning,assertWithSideEffect)
 }}}

 I believe these are false positives, because these methods both don't have
 side effects and we want not to call them in case someone uses `NDEBUG`,
 as these are the checks he wanted to turn off by that.

 * Bunch of unmatched suppressions. I don't know what to do with them, as
 they are needed for older cppchecks, but are noisy on the new ones.
 Possibly suppress the warning about bad suppressions.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3005>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development