BIND 10 #2979: perfdhcp segfaults

[BIND 10 Development]

#2979: perfdhcp segfaults
-------------------------------------+-------------------------------------
            Reporter:  stephen       |                        Owner:
                Type:  defect        |  UnAssigned
            Priority:  low           |                       Status:
           Component:  perfdhcp      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130620
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => UnAssigned
 * status:  assigned => reviewing


Comment:

 Provided patch does not resolve the actual problem. In practice, it
 prevents the program from entering the section of the code where the
 actual bug is. The culprit section is responsible for garbage collecting
 timed out packets. When packet is considered timed out, it is erased from
 the list where sent packets are tracked. The internal pointer used to
 track the ''next sent'' packet is not updated on removal of the timed out
 packet. In some cases it may cause the internal pointer to invalidate and
 lead to undefined behaviour. The proper fix updates the internal pointer
 to point to a valid element on the list on removal of the element it
 points to.

 Please review this fix on the trac2979 branch.

 Proposed !Changelog entry
 {{{
 6XX.    [bug]           marcin
         perfdhcp: Fixed a bug in whereby the application was sporadically
         crashing when timed out packets were garbage collected.
         (Trac #2979, git abcd)

 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/2979#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development