BIND 10 #2726: New cppcheck reports
BIND 10 Development
do-not-reply at isc.org
Tue Jun 18 08:31:49 UTC 2013
#2726: New cppcheck reports
-------------------------------------+-------------------------------------
Reporter: muks | Owner:
Type: defect | vorner
Priority: medium | Status:
Component: Unclassified | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130625
Sub-Project: DNS | Resolution:
Estimated Difficulty: 5 | CVSS Scoring:
Total Hours: 3.30 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by muks):
* owner: muks => vorner
Comment:
Hi Michal
The changes look OK. In the case of commit
`007341505307a53b43802c747fe09435346bbf46`, would having two constructors
help?
{{{
/// point to anything defined in the .spec file)
class DataNotFoundError : public isc::Exception {
public:
+ DataNotFoundError(const char* file, size_t line, const std::string&
what) :
+ isc::Exception(file, line, what) {}
+
DataNotFoundError(const char* file, size_t line, const char* what) :
isc::Exception(file, line, what) {}
};
}}}
You can go ahead and merge this anyway.
--
Ticket URL: <http://bind10.isc.org/ticket/2726#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list