BIND 10 #2441: update in-memory data source so it can load RRs in any order
BIND 10 Development
do-not-reply at isc.org
Mon Mar 4 10:11:21 UTC 2013
#2441: update in-memory data source so it can load RRs in any order
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner: muks
Type: task | Status:
Priority: medium | reviewing
Component: data source | Milestone:
Keywords: | Sprint-20130305
Sensitive: 0 | Resolution:
Sub-Project: DNS | CVSS Scoring:
Estimated Difficulty: 4 | Defect Severity: N/A
Total Hours: 0 | Feature Depending on Ticket:
| loadzone-ng
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => muks
Comment:
Hello
I find the changelog confusing, especially the part about seeing the type
before. Could you try reformulating it, possibly with saying the RRsets
don't need to be consecutive any more?
This comment contains „existing“ one too many times:
{{{#!c++
// Create a new RdataSet, merging any existing existing NSEC3 data
}}}
Also, the original code collated the RRsets before it put them into the
zone updater. Currently, it doesn't do so. I'm not sure how fast it'll be
to repeatedly merge the RRs together, because each time a new (larger) one
is allocated. Couldn't it lead to severe memory fragmentatiton? Would it
be better to keep the collating and use the merging only at the times the
RRs are not consecutive? On the other hand, this code is simpler, which is
an advantage, so I don't know.
--
Ticket URL: <http://bind10.isc.org/ticket/2441#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list