BIND 10 #2441: update in-memory data source so it can load RRs in any order

[BIND 10 Development]

#2441: update in-memory data source so it can load RRs in any order
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  vorner
            Priority:  medium        |                       Status:
           Component:  data source   |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130319
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => vorner


Comment:

 Hi Michal

 Replying to [comment:8 vorner]:
 > I find the changelog confusing, especially the part about seeing the
 > type before. Could you try reformulating it, possibly with saying the
 > RRsets don't need to be consecutive any more?

 Does this look better:
 {{{
 XYZ.    [func]          muks
         The zone data loader now accepts RRs in any order during load.
         Before it used to reject adding non-consecutive RRsets. It
         expected records for a single owner name and its type to be
         grouped together. These restrictions are now removed.
         (Trac #2441, git ...)
 }}}

 > This comment contains „existing“ one too many times:
 > {{{#!c++
 > // Create a new RdataSet, merging any existing existing NSEC3 data
 > }}}

 Fixed. :)

 > Also, the original code collated the RRsets before it put them into
 > the zone updater. Currently, it doesn't do so. I'm not sure how fast
 > it'll be to repeatedly merge the RRs together, because each time a new
 > (larger) one is allocated. Couldn't it lead to severe memory
 > fragmentatiton? Would it be better to keep the collating and use the
 > merging only at the times the RRs are not consecutive? On the other
 > hand, this code is simpler, which is an advantage, so I don't know.

 I've brought back the old functionality of the ZoneDataLoader for this.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2441#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development