BIND 10 #2790: Lettuce tests timing & missed messages

BIND 10 Development do-not-reply at isc.org
Fri Mar 15 12:09:20 UTC 2013


#2790: Lettuce tests timing & missed messages
-------------------------------------+-------------------------------------
            Reporter:  vorner        |                        Owner:
                Type:  defect        |                       Status:  new
            Priority:  medium        |                    Milestone:
           Component:  Unclassified  |  Sprint-20130319
            Keywords:                |                   Resolution:
           Sensitive:  0             |                 CVSS Scoring:
         Sub-Project:  Core          |              Defect Severity:  N/A
Estimated Difficulty:  9             |  Feature Depending on Ticket:
         Total Hours:  0             |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jelte):

 e.g. as a very quick suggestion (no doubt I'm missing 15 error cases
 here):

 {{{
 diff --git a/src/bin/zonemgr/zonemgr.py.in b/src/bin/zonemgr/zonemgr.py.in
 index 59900c4..b85b60e 100755
 --- a/src/bin/zonemgr/zonemgr.py.in
 +++ b/src/bin/zonemgr/zonemgr.py.in
 @@ -667,7 +667,14 @@ class Zonemgr:
          self.running = True
          try:
              while not self._shutdown_event.is_set():
 -                self._module_cc.check_command(False)
 +                fileno = self._module_cc.get_socket().fileno()
 +                try:
 +                    (reads, _, _) = select.select([fileno], [], [])
 +                except select.error as se:
 +                    if se.args[0] != errno.EINTR:
 +                        raise
 +                if fileno in reads:
 +                    self._module_cc.check_command(True)
          finally:
              self._module_cc.send_stopping()
 }}}

 with that trac2198_5 passes all lettuce tests on my single-core debian VM

-- 
Ticket URL: <http://bind10.isc.org/ticket/2790#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list