BIND 10 #1086: Ensure message consistency when outputting address+port or name+type+class

[BIND 10 Development]

#1086: Ensure message consistency when outputting address+port or name+type+class
-------------------------------------+-------------------------------------
            Reporter:  stephen       |                        Owner:
                Type:  enhancement   |                       Status:  new
            Priority:  medium        |                    Milestone:
           Component:  logging       |  Previous-Sprint-Proposed
            Keywords:                |                   Resolution:
           Sensitive:  0             |                 CVSS Scoring:
         Sub-Project:  DNS           |              Defect Severity:  N/A
Estimated Difficulty:  5             |  Feature Depending on Ticket:
         Total Hours:  0             |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by shane):

 I did a few quick greps.

 First, lets see if we used any printf-style output with #port:

 {{{
 $ find . -type f | xargs grep "#%d"
 Binary file ./.git/objects/pack/pack-
 fad569f01b61428e6f9164903d4f47580abef7d7.pack matches
 }}}

 Nope. What about ostream-style with a character '#':

 {{{
 $ find . -type f | xargs grep "#' *<<"
 ./src/lib/server_common/client.cc:       << '#' <<
 impl_->request_.getRemoteEndpoint().getPort();
 }}}

 One occurrence.

 And ostream-style with a string "#":

 {{{
 $ find . -type f | xargs grep '#" *<<'
 ./examples/host/host.cc:        //cout << "Address: " << address << "\n" ;
 // "#" << port << "\n";
 ./src/lib/dhcp/option_custom.cc:            tmp << "#" <<
 std::distance(fields.begin(), field) << " "
 ./src/lib/dhcp/option_custom.cc:            tmp << "#" << i << " "
 ./src/lib/acl/tests/logcheck.h:                EXPECT_TRUE(run[i]) <<
 "Check #" << i << " did not run.";
 ./src/lib/acl/tests/logcheck.h:                EXPECT_FALSE(run[i]) <<
 "Check #" << i << "did run.";
 }}}

 Looks like there is a commented-out version in the host examples that we
 need to get rid of.

 And lets see if we used a string concatenate to build something:

 {{{
 $ find . -type f | xargs grep '#" *+'
 $ find . -type f | xargs grep "#' *+"
 Binary file ./.git/objects/pack/pack-
 f976871e7ebb588ae03fbf78678f7738fca7c796.pack matches
 Binary file ./.git/objects/pack/pack-
 fad569f01b61428e6f9164903d4f47580abef7d7.pack matches
 Binary file ./.git/objects/pack/pack-
 fad569f01b61428e6f9164903d4f47580abef7d7.idx matches
 }}}

 Doesn't look like it.

 So, I may have missed some possible patterns, but I think that this ticket
 basically involves changing one line and deleting a commented-out line.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1086#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development