BIND 10 #2784: perfdhcp cores when given command line "-6" and v4 server address

[BIND 10 Development]

#2784: perfdhcp cores when given command line "-6" and v4 server address
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:
                Type:  defect        |  UnAssigned
            Priority:  medium        |                       Status:
           Component:  perfdhcp      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130328
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tmark):

 * owner:  tmark => UnAssigned
 * status:  assigned => reviewing


Comment:

 IOAddress will construct an object from a string address so long as the
 address is valid
 whether it is v4 or a v6 address, and then it sets the IOAddress family
 member accordingly.
 This issue here is that we have a valid address, and hence a valid
 IOAddress object, it just isn't the IPv family we are expecting, so when
 we try to treat it as v6 address bad things happen.

 I added logic to perfdhcp/test_control.cc to check for a mismatch between
 the commnd line arguments for ip version and server:

 If an IOAddress object is successfully created from the server value, then
 it's family is checked against the requested ip version. If they do not
 match it throws an InvalidParameter
 exception causing the process to exit gracefully.

 I also added unit tests to verify mismatch detection.

 Attached is output from perfdhcp showing proper behavior as well as
 perfdchp unit test logs.
 The following ChangeLog entry is suggested:

 "
 5xx.    [bug]       tmark
     Perdhcp will now exit gracefully if the command line argument for Ip
 version
     (-4 or -6) does not match the command line argument given for the
 server.
     Prior to this perfdhcp would core when given an Ip version of -6 but a
 valid
     IPv4 address for server.
     (Trac #2784, git 2f3d1fe8c582c75c98b739e0f7b1486b0a9141ca)
 "

-- 
Ticket URL: <http://bind10.isc.org/ticket/2784#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development