BIND 10 #1938: why ZONEMGR_UNKNOWN_ZONE_NOTIFIED ?
BIND 10 Development
do-not-reply at isc.org
Fri Mar 22 07:12:38 UTC 2013
#1938: why ZONEMGR_UNKNOWN_ZONE_NOTIFIED ?
-------------------------------------+-------------------------------------
Reporter: jreed | Owner:
Type: defect | jinmei
Priority: high | Status:
Component: secondary | reviewing
manager | Milestone:
Keywords: | Sprint-20130402
Sensitive: 0 | Resolution:
Sub-Project: DNS | CVSS Scoring:
Estimated Difficulty: 5 | Defect Severity:
Total Hours: 0 | Medium
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
Thanks for the review.
Replying to [comment:20 jelte]:
> All changesets look fine in general, a few minor comments:
>
> - I replaced a few occurrences of 'readble' with 'readable' in the
comments
These are good (although they existed before this branch:-)
> - it's not in master yet, but the NOTIFY_OUT_REPLY_RECEIVED should
probably use the AddressFormatter class instead of raw address:port so
that v6 addresses get blockquotes around them (the class is introduced in
#1086, but whichever of these two branches is merged last should make the
change I guess)
ack.
As for the lettuce tests (in your next comment), I tried various
"lightweight" workaround including using 'new' twice (according to
your last suggestion), but none seemed to work reliably. So I decided
to clarify and update the meaning of 'new' in terrain.py, and update
some features so they will work with this clarification (and,
if I understand it correctly, some cases were not really safe due to
the possible timing issues of 'new' even before this clarification;
they should have been fixed anyway).
All tests basically seem to pass (the only exception in my environment
is the XFRIN_XFR_TRANSFER_STARTED failure, but we know that's a
different issue), so I think this change doesn't introduce additional
regression, but please review and check it in your environment.
--
Ticket URL: <http://bind10.isc.org/ticket/1938#comment:22>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list