BIND 10 #2827: v6 relays support in Kea

[BIND 10 Development]

#2827: v6 relays support in Kea
-------------------------------------+-------------------------------------
            Reporter:  tomek         |                        Owner:  tomek
                Type:  enhancement   |                       Status:
            Priority:  medium        |  reviewing
           Component:  dhcp6         |                    Milestone:
            Keywords:                |  Sprint-DHCP-20130328
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  UnAssigned => tomek


Comment:

 Reviewed commit 859e0b3e82d4cc5270d8fb557f0120dc35edd1a3

 Please update the copyright dates in modified files.

 '''!ChangeLog'''
 Changes are limited to !''libdhcp++!'' so maybe reflect that in the
 changelog by replacing !''b10-dhcp6!'' with !''libdhcp++''.

 '''pkt6.cc'''
 Please update the copyright date.

 Pkt6::len(): wouldn't it be better to call calculateRelaySizes() on packet
 reception - when unpackUDP() is called? The ''Pkt6::unpackUDP()'' is
 called once for the specific packet while ''Pkt6::len()'' can be called
 several times from different parts of the code. This will cause re-
 calculation.

 Pkt6::calculateRelaySizes(): Proposing alternative to the loop in this
 function. However, this is really minor matter so you don't need to pay
 attention to this proposal. :-)
 {{{
 for (int relay_index = relay_info_.size(); relay_index > 0; --relay_index)
 {
     relay_info_[relay_index - 1].relay_msg_len_ = len;
     len += getRelayOverhead(relay_info_[relay_index - 1]);
 }
 }}}

 Pkt6::packUDP():
 Having some more comments would be useful in the part of the function that
 packs relay headers and options.

 '''pkt6.h'''
 getRelayOption(): this function is not documented.

 directLen(): IMO, it could be better to say !''if received message was not
 relayed!'' because !''directly!'' may be ambiguous.
 Also, this function can be declared const.


 getRelayOverhead(): the !''relay!'' parameter is not documented.
 This function could be declared const.


 '''pkt6_unittest.cc'''
 It is probably not a good idea to...
 {{{
 using namespace boost;
 }}}

 On Solaris this will shade the uint8_t type which will result in
 compilation error.

 capture2(): typo in the comment. s/related/relayed.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2827#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development