BIND 10 #2391: support generic version of rdata::createRdata(text) in AFSDB, DLV RDATA

[BIND 10 Development]

#2391: support generic version of rdata::createRdata(text) in AFSDB, DLV RDATA
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  pselkirk
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130402
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  3             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => pselkirk


Comment:

 Hello

 Few notes:

 Some of the changes contain tabs instead of spaces.

 The doxygen of the new constructor seems to be a copy-paste from MX. It
 talk about Exchange name, for example, which doesn't seem to be mentioned
 at all by the AFSDB rfc.

 Also, the tests seem to crash for me:

 {{{
 [ RUN      ] Rdata_AFSDB_Test.createFromLexer
 run_unittests: /usr/include/boost/smart_ptr/shared_ptr.hpp:418:
 boost::shared_ptr<T>::reference boost::shared_ptr<T>::operator*() const
 [with T = isc::dns::rdata::Rdata; boost::shared_ptr<T>::reference =
 isc::dns::rdata::Rdata&]: Assertion `px != 0' failed.
 /bin/bash: line 5:  3315 Aborted                 (core dumped) /bin/bash
 ../../../../libtool --mode=execute ${dir}$tst
 FAIL: run_unittests
 ===================================
 }}}

 Anyway, applying similar changes to MX might be a good idea, so some code
 duplication is reduced.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2391#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development