BIND 10 #2721: Write unit test for Ticket 2719
BIND 10 Development
do-not-reply at isc.org
Mon Mar 25 14:18:02 UTC 2013
#2721: Write unit test for Ticket 2719
-------------------------------------+-------------------------------------
Reporter: jwright | Owner: tmark
Type: task | Status:
Priority: medium | reviewing
Component: Unclassified | Milestone:
Keywords: | Sprint-DHCP-20130328
Sensitive: 0 | Resolution:
Sub-Project: DHCP | CVSS Scoring:
Estimated Difficulty: 0 | Defect Severity: N/A
Total Hours: 0 | Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by marcin):
* owner: marcin => tmark
Comment:
Replying to [comment:6 tmark]:
> > '''checkIA_NA''':
> > This line the code:
> > {{{
> > boost::shared_ptr<Option6IA> ia =
boost::dynamic_pointer_cast<Option6IA>(tmp);
> > }}}
> >
> > may result in !''ia!'' being NULL pointer. Please consider adding
!''ASSERT_TRUE(ia)!'' before using it further in the code.
>
> This line is already followed by a call to ASSERT_TRU(ia).
>
Not it is not.
> 5XX. [func] tmark
> b10-dhcp6: Added unit tests for handling requests when no
> v6 subnets are configured/defined. Testing these conditions
> was overlooked during implementation of Trac #2719.
> (Trac #2721, git 03b6bd8461d7aee84ac34da1c737fed4a3c16c22)
> (Trac #2721, git c533897b58690ab30d12dd9837de04e08d840ee3)
Why specify two commits for #2721?
--
Ticket URL: <http://bind10.isc.org/ticket/2721#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list