BIND 10 #1086: Ensure message consistency when outputting address+port or name+type+class

[BIND 10 Development]

#1086: Ensure message consistency when outputting address+port or name+type+class
-------------------------------------+-------------------------------------
            Reporter:  stephen       |                        Owner:
                Type:  enhancement   |  vorner
            Priority:  medium        |                       Status:
           Component:  logging       |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130402
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  2             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 Replying to [comment:14 vorner]:
 > Hello
 >
 > What is meant with the replacable address with the AddressFormatter?
 Does it make sense, in python? Can that be a copy-paste of C++ code by
 accident?
 >

 The 'replacable address' bit was taken from the other (python)
 implementation, from what I can tell the idea would be to save a couple of
 AddressFormatter instantiations by adding a setAddress() (which would only
 internally update PyObject* pointers). I don't think it'd be very useful,
 but IMO the comment mostly shows that there are other approaches that
 could be considered :) I wouldn't be very much opposed to removing the
 consideration here altogether.

 > Do the formatter take address-family or address-port?
 > {{{#!python
 >             logger.info(BIND10_STARTING_PROCESS_PORT_ADDRESS,
 >                         self.curproc, AddressFormatter(address, port))
 > }}}

 Woops, that would error. Added test for this failure and fixed the call.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1086#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development