BIND 10 #2890: Resolve disparaties between ISC_DHCP and b10-dhcp4 in packet handling

[BIND 10 Development]

#2890: Resolve disparaties between ISC_DHCP and b10-dhcp4 in packet handling
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:
                Type:  task          |                       Status:  new
            Priority:  medium        |                    Milestone:  DHCP
           Component:  dhcp4         |  Outstanding Tasks
            Keywords:                |                   Resolution:
           Sensitive:  0             |                 CVSS Scoring:
         Sub-Project:  DNS           |              Defect Severity:  N/A
Estimated Difficulty:  0             |  Feature Depending on Ticket:
         Total Hours:  0             |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Description changed by tmark:

Old description:

> During v4.robustness test creation (Trac# 2600) disparities between how
> ISC_DHCP and b10-dhcp4 respond to certain packet content came to light.
> For example:
>
> 1. In response to a DHCPREQUEST, sent to a server at 172.16.1.1, with
> giaddr=172.16.1.4, no ciaddr, and request address of 186.16.1.18
> ISC_DHCP sends a NAK, while b10-dhcp4 sends an OFFER.
>
> 2. In response to a DHCPDISCOVER with relay agent option set o "blah blah
> blah", ISC_DHCP detects invalid packet via parsing error, while b10-dhcp4
> extends an offer.
>
> Trac# 2889 was created to codify requirements for RFC2131, Section 4.3.
> In conjunction with that effort identification reconciliation of
> differing behavior between of ISC_DHCP and b10-dhcp4 to various packet
> content should be conducted.
>
> This should include codification of what is and is not a valid inbound
> packet.

New description:

 During v4.robustness test creation (Trac# 2600) disparities between how
 ISC_DHCP and b10-dhcp4 respond to certain packet content came to light.
 For example:

 1. In response to a DHCPREQUEST, sent to a server at 172.16.1.1, with
 giaddr=172.16.1.4, no ciaddr, and request address of 186.16.1.18  ISC_DHCP
 sends a NAK, while b10-dhcp4 sends an OFFER.

 2. In response to a DHCPREQUEST, sent to a server at 172.16.1.1, with no
 giaddr of 172.16.1.4, no ciaddr, and no request address,  ISC_DHCP finds
 no matching lease and does not respond, b10-dhcp4 responds with an OFFER.

 3. In response to a DHCPDISCOVER with relay agent option set o "blah blah
 blah", ISC_DHCP detects invalid packet via parsing error, while b10-dhcp4
 extends an offer.


 Trac# 2889 was created to codify requirements for RFC2131, Section 4.3.
 In conjunction with that effort identification reconciliation of differing
 behavior between of ISC_DHCP and b10-dhcp4 to various packet content
 should be conducted.

 This should include codification of what is and is not a valid inbound
 packet.

--

-- 
Ticket URL: <http://bind10.isc.org/ticket/2890#comment:1>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development