BIND 10 #2770: dhcp serverid file should not be in the toplevel datadir

[BIND 10 Development]

#2770: dhcp serverid file should not be in the toplevel datadir
-------------------------------------+-------------------------------------
            Reporter:  jreed         |                        Owner:
                Type:  defect        |  UnAssigned
            Priority:  low           |                       Status:
           Component:  Unclassified  |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130328
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by tmark):

 Replying to [comment:5 jreed]:
 > What is purpose of creating the directory during installation? (I
 already see other files kept there: logger_lockfile, various socket files,
 and bind10 configuration files.)
 >

 While it is true that other files are kept there and two other Makefiles
 address creating this directory, (bin/cfgmgr and bin/cmdctl), this is
 somewhat by happenstance in that those two creates are based on ${prefix}
 not ${localstatedir}.  In the case when localstatedir equals prefix then
 everything is alright.  In the case where localstatedir is specified and
 is different, the directory will not exist.

 It may be that these other two Makefiles should be changed to use
 ${localstatedir}.  Even so, I would recommend the directory installation
 be included as part of lib/dhcpsrv to remove issues should the build order
 change.



 > If created during install it should create in $(DESTDIR).

 I have added DESTDIR as suggested.  I missed this before.

 >
 > changelog has typo: dchp
 >
 > This minor change works for me.

 Done.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2770#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development