BIND 10 #1909: "make check" fails if sqlite3 command line tool not installed
BIND 10 Development
do-not-reply at isc.org
Thu May 2 04:15:54 UTC 2013
#1909: "make check" fails if sqlite3 command line tool not installed
-------------------------------------+-------------------------------------
Reporter: shane | Owner:
Type: defect | jinmei
Priority: medium | Status:
Component: build system | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130514
Sub-Project: Core | Resolution:
Estimated Difficulty: 3 | CVSS Scoring:
Total Hours: 0 | Defect Severity: Low
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by muks):
* owner: muks => jinmei
Comment:
Hi Jinmei
Replying to [comment:10 jinmei]:
> > > - I suggest moving the sqlite3 related part of configure.ac under
> > > m4macros/ at this opportunity. sqlite3 is (and will probably
> > > remain) a DNS specific dependency, so it will help make it easier
to
> > > select features (DNS, DHCP, etc) if we separate uncommon settings
> > > into an external macro.
> >
> > Done.
>
> This generally looks good, but I have one question: do we need these?
> {{{
> AC_SUBST(SQLITE_CFLAGS)
> AC_SUBST(SQLITE_LIBS)
> }}}
>
> These don't seem to be included in the original configure.ac.
Hmm.. I did that out of habit. I guess `PKG_CHECK_MODULES` now
`AC_SUBST`s them too. At some point in the past it didn't do that.
Removed now.
I've also `EXTRA_DIST`ed those m4 files in `m4macros/` in case someone
wants them to `autoreconf` the tree (some packagers do that when they
modify `configure.ac`).
`distcheck` passes on the branch.
--
Ticket URL: <http://bind10.isc.org/ticket/1909#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list