BIND 10 #2252: Implement counters into Xfrin (1/3)

[BIND 10 Development]

#2252: Implement counters into Xfrin (1/3)
-------------------------------------+-------------------------------------
            Reporter:  naokikambe    |                        Owner:
                Type:  enhancement   |  jinmei
            Priority:  medium        |                       Status:
           Component:  xfrin         |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130514
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  16.75         |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by naokikambe):

 * owner:  naokikambe => jinmei


Comment:

 Hello, sorry for my late response.

 Replying to [comment:32 jinmei]:
 > And the "fix" is to set poll-interval to 1 (then in the second case
 > "check initial statistics" triggers another polling and b10-stats will
 > get the latest value) and assert the counter is 1?
 >
 > If so, I think the previous workaround is less ugly, which, if I
 > remember it, is to assert the counter is either 0 or 1 (with
 > commenting why).  To me the current fix has the following issues:
 > - it's not clear why we need to use that specific value of
 >   poll-interval.
 > - smaller poll-interval values will cause noisy log output.  it's
 >   inconvenient when we need to examine the log output to debug a test
 >   failure.

 The config change is for avoiding timeout of lettuce test. But I reverted
 it to the default(60). And I updated the lettuce tests to expect the value
 to be 0 or 1. And I also added notes.  If the notes are still hard for you
 to understand, I'll revise them. Please review again.

 {{{
 0475216 [2252] .Xfrout.socket.unixdomain.open is either expected to be 0
 or 1, and add notes
 8f4a354 [2252] revert poll-interval to the default value
 }}}

 Regards,

-- 
Ticket URL: <http://bind10.isc.org/ticket/2252#comment:34>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development