BIND 10 #2521: support generic version of rdata::createRdata(text) in RRSIG, DHCID, OPT RDATA

[BIND 10 Development]

#2521: support generic version of rdata::createRdata(text) in RRSIG, DHCID, OPT
RDATA
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  pselkirk
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130514
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by pselkirk):

 Replying to [comment:27 jinmei]:
 > Replying to [comment:25 pselkirk]:
 > > * I borrowed Mukund's string aggregator code from DNSKEY. (OTOH, I
 think the better long-term solution would be to add a read-to-EOL method
 to MasterLexer.)
 >
 > Maybe we should do it within this ticket, then?  But we've already
 > spent quite some time for it, so it may be better to defer it to a
 > separate ticket.  I'd leave it to you.

 I'd prefer to do it in a separate ticket, because a) I don't want to
 expand the scope of this ticket, and b) this cuts across every RR type
 that includes base64 data.

 > '''rrsig_46.cc'''
 > - This one still seems open: `signer` can be a reference, which is
 >   possibly a bit more efficient:
 > {{{#!cpp
 >     const Name& signer = createNameFromLexer(lexer, origin);
 >     //const Name signer = createNameFromLexer(lexer, origin);
 > }}}
 >   It's a minor point, though, so if you simply decided not to adopt
 >   it, I'm okay with it, but I was not sure whether it was actually
 >   overlooked.

 Sorry, that was an oversight.

 > '''dhcid_49.cc'''
 > - What's "key data" in this comment?

 It was a cut-and-paste from dnskey_48.cc.

 >   If this means the entire DHCID RDATA, BIND 9 actually rejects empty
 >   data.  I'm not sure if it's intentional or not, though (but it
 >   rejects the empty case both for from-text and from-wire, so at least
 >   it's consistent).

 I interpreted our previous conversation about removing length checks to
 mean that a length of 0 is acceptable. (I'm actually relieved to be wrong,
 because it didn't feel right.) I will re-add a "!=0" length check.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2521#comment:29>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development