BIND 10 #2823: complete removing threads from stats tests
BIND 10 Development
do-not-reply at isc.org
Tue May 7 13:51:39 UTC 2013
#2823: complete removing threads from stats tests
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: defect | jinmei
Priority: medium | Status:
Component: statistics | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130514
Sub-Project: DNS | Resolution:
Estimated Difficulty: 5 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => jinmei
Comment:
Hello
Replying to [comment:10 jinmei]:
> > What is the purpose of this test? Does it really test that the test
code throws an exception?
> > {{{#!python
> > def test_init_hterr(self):
> > class FailingStatsHttpd(SimpleStatsHttpd):
> > def open_httpd(self):
> > raise stats_httpd.HttpServerError
> > self.assertRaises(stats_httpd.HttpServerError,
FailingStatsHttpd)
> > }}}
>
> Hmm, on a closer look, the original test (implicitly) checks one more
> thing (in an expensive way): stats-httpd should tell !ConfigMgr of its
> departure (by send_stopping()). I believe it's sufficient to check
> if close_mccs() is called, so I revised the test so it checks this
> condition, too.
The test was failing for me, see the commit in the branch for details.
If you agree, I think this can be merged.
--
Ticket URL: <http://bind10.isc.org/ticket/2823#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list