BIND 10 #2823: complete removing threads from stats tests

BIND 10 Development do-not-reply at isc.org
Tue May 7 20:36:48 UTC 2013


#2823: complete removing threads from stats tests
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  defect        |  jinmei
            Priority:  medium        |                       Status:
           Component:  statistics    |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130514
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  3.65          |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:12 vorner]:

 > > > What is the purpose of this test? Does it really test that the test
 code throws an exception?
 [...]
 > > Hmm, on a closer look, the original test (implicitly) checks one more
 > > thing (in an expensive way): stats-httpd should tell !ConfigMgr of its
 > > departure (by send_stopping()).  I believe it's sufficient to check
 > > if close_mccs() is called, so I revised the test so it checks this
 > > condition, too.
 >
 > The test was failing for me, see the commit in the branch for details.
 >
 > If you agree, I think this can be merged.

 Thanks, the change is okay for me (I'm not sure why it worked in my
 environment though).  I also made one last-minute change directly
 to master: d2861ef.  I believe it's sufficiently minor to have
 explicit review, but say so if you think it has an issue.

 Closing the ticket for now anyway.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2823#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list