BIND 10 #2521: support generic version of rdata::createRdata(text) in RRSIG, DHCID, OPT RDATA

BIND 10 Development do-not-reply at isc.org
Tue May 7 22:22:41 UTC 2013


#2521: support generic version of rdata::createRdata(text) in RRSIG, DHCID, OPT
RDATA
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130514
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by pselkirk):

 * owner:  pselkirk => jinmei


Comment:

 Replying to [comment:31 jinmei]:
 > - documentation (in any case "key data" should be reworded as
 >   discussed above)

 Removed that discussion from the string constructor documentation.

 > - "from wire" constructor (it currently accepts empty data, and has a
 >   bug with std::vector in that case)

 Added a zero-length check, and a unit test case.

 > Also, maybe a matter of taste, but I'd use vector::at() ...

 Currently only NSEC3::compare() and NSEC3PARAM::compare() use
 vector::at(). No toWire() methods use it.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2521#comment:33>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list