BIND 10 #2521: support generic version of rdata::createRdata(text) in RRSIG, DHCID, OPT RDATA

[BIND 10 Development]

#2521: support generic version of rdata::createRdata(text) in RRSIG, DHCID, OPT
RDATA
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  pselkirk
            Priority:  medium        |                       Status:
           Component:  libdns++      |  closed
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130514
         Sub-Project:  DNS           |                   Resolution:  fixed
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  4             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by pselkirk):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 Merged to the master branch in commit
 c6603decaadcd33ccf9aee4a7b22447acec4b7f6:
 {{{
 * 65b7adb [2521] add 0-length check to DHCID from-wire constructor
 * dac1394 [2521] remove an unused Rdata_DHCID_Test method
 * 885821d [2521] better way of handling empty DHCID RDATA
 * 225a1e0 [2521] RRSIG signer can be a reference, maybe a bit more
 efficient
 * caefbb6 [2521] DHCDID RDATA cannot be empty
 * 5045f86 [2521] minor simplification: initialize mem var in the list when
 possible.
 * 94d255e [2521] a minor style nit: adjusted a '*' position per style
 guideline.
 * bec8813 [2521] divide Rdata_RRSIG_Test.badText into many smaller tests
 * e8655ab [2521] style cleanup: remove trailing whitespace
 * 23db9e9 [2521] further DHCID review updates
 * 2a6431a [2521] further RRSIG review updates
 * 1d3b43a [2521] style cleanup: removed a space after EOL
 * d24f908 [2521] remove erroneous whitespace in RRCollator test data
 * 6b98341 [2521] more DHCID unit tests
 * f3ca4f3 [2521] RFC4034 only allows unsigned int in the RRSIG Original
 TTL field
 * b409334 [2521] more RRSIG unit tests
 * 4c8efe3 [2521] Handle space-separated base-64 digest in DHCID, per
 Jinmei's review.
 * 3bfd98d [2521] Rearrange RRSIG parser error handling, per Jinmei's
 review.
 * d06ff54 [2521] doc cleanup for OPT, per Jinmei's review
 * 858d5fa [2521] constify
 * 2fdd355 [2521] style cleanups: folded a long line; constify variables
 * c9095ff [2521] add MasterLexer constructor for DHCID
 * 870cc9b [2521] enabled previously disabled rrsig test
 * fdb992f [2521] add MasterLexer constructor for RRSIG
 * 9ac31c2 [2521] add minimal doxygen comments for string & lexer
 constructors
 * 5629c01 [2521] add MasterLexer constructor for OPT
 }}}

 Resolving as fixed. Thank you for the reviews, Jinmei.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2521#comment:36>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development