BIND 10 #2836: update in-memory zone loading so it can work with shmem segment
BIND 10 Development
do-not-reply at isc.org
Thu May 16 14:50:08 UTC 2013
#2836: update in-memory zone loading so it can work with shmem segment
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: task | jinmei
Priority: medium | Status:
Component: data source | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130528
Sub-Project: DNS | Resolution:
Estimated Difficulty: 4 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| shared memory data source
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => jinmei
Comment:
Hello
Replying to [comment:21 jinmei]:
> - install: we should move the call to `resetHeader` in the catch
> block:
> {{{#!cpp
> } catch (const isc::util::MemorySegmentGrown&) {
> segment_.resetHeader();
> }
> }}}
> and there's now no need for calling it at the end of the method,
> because addZone() ensures no relocation on successful return
> (see above).
Well, a test checks that it is called. I guess it is just safer that way
and no real problem, so I left it at that (but it is called even after
unsuccessful attempt too).
--
Ticket URL: <http://bind10.isc.org/ticket/2836#comment:23>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list