BIND 10 #2522: support generic version of rdata::createRdata(text) in RP, MINFO, TSIG RDATA

BIND 10 Development do-not-reply at isc.org
Thu May 16 15:28:44 UTC 2013


#2522: support generic version of rdata::createRdata(text) in RP, MINFO, TSIG
RDATA
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  pselkirk
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130528
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by pselkirk):

 Replying to [comment:11 jinmei]:
 > '''tsig_250.h'''
 > - is there a reason for making `TSIGImpl` public?  Although wouldn't
 >   matter much in practice, it would be generally better to be hidden
 >   as much as possible due to its nature.  So in that sense I thought
 >   the previous definition makes more sense.

 I changed it for consistency with similar Rdata classes.

 `struct *Impl` is declared publicly in DNSKEY, HINFO, NAPTR, NSEC3,
 NSEC3PARAM, NSEC, RRSIG, and SRV.

 It's declared privately in DLV, DS, SPF, and TXT - the classes that use
 `*LikeImpl` templates.

 I don't object to making it private, but I'd want to make it private in
 all the other classes as well.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2522#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list