BIND 10 #2930: Sending notifications over msgq

[BIND 10 Development]

#2930: Sending notifications over msgq
-------------------------------------+-------------------------------------
            Reporter:  vorner        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  Inter-module  |  reviewing
  communication                      |                    Milestone:
            Keywords:                |  Sprint-20130528
           Sensitive:  0             |                   Resolution:
         Sub-Project:  Core          |                 CVSS Scoring:
Estimated Difficulty:  3             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |  shared memory data source
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 '''other'''

 - not sure if it's related, but cmdctl unittest fails for this branch:
 {{{
 Running test: cmdctl_test.py
 ....................................E
 ======================================================================
 ERROR: test_wrap_sock_in_ssl_context (__main__.TestSecureHTTPServer)
 ----------------------------------------------------------------------
 Traceback (most recent call last):
   File
 "/Users/jinmei/src/isc/git/bind10-2930/src/bin/cmdctl/tests/cmdctl_test.py",
 line 741, in test_wrap_sock_in_ssl_context
     BUILD_FILE_PATH + 'cmdctl-certfile.pem')
   File "/Users/jinmei/src/isc/git/bind10-2930/src/bin/cmdctl/cmdctl.py",
 line 610, in _wrap_socket_in_ssl_context
     raise socket.error
 socket.error
 }}}
 - I'm assuming 9d7bd1274b7ff4578e108c8c13bad81cc2867d14 of master is
   part of this branch and should be reviewed.  Is there other such
   commit?
 - are we going to describe the concept of notification in API docs?
   or is there already such description?


 '''ccsession.h'''

 - I'd clarify this notify() is a non blocking operation.

 - is there a restriction of the type of params?  can it be, e.g., an
   integer?
 - any exceptions?
 - on a related note of the concept description, I'd like to describe
   what kind of message will be sent, even if the user doesn't have to
   know about it.

 '''ccsession_unittest.cc'''

 - missing test case: the case when param is not specified
 - same for the cases with invalid form of params (if there's a
 restriction)
 - maybe missing exception cases

 '''ccsession.py'''

 - same comments as those for .cc on documentation apply here

 - also, while not specific to this branch, ideally we should unify the
   description of these documentations as much as possible.
 - also, for the Python case I'd clarify the expected type of each
   parameter.

 '''ccsession_test.py'''

 - same comments as those for .cc on documentation apply here
 - what if we pass bogus types of parameters, like an integer for the
   group?

-- 
Ticket URL: <http://bind10.isc.org/ticket/2930#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development