BIND 10 #2522: support generic version of rdata::createRdata(text) in RP, MINFO, TSIG RDATA
BIND 10 Development
do-not-reply at isc.org
Wed May 22 17:07:34 UTC 2013
#2522: support generic version of rdata::createRdata(text) in RP, MINFO, TSIG
RDATA
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: task | jinmei
Priority: medium | Status:
Component: libdns++ | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130528
Sub-Project: DNS | Resolution:
Estimated Difficulty: 5 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| loadzone-ng
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:19 pselkirk]:
> Ready for re-review.
It looks mostly okay, but these two points seem to remain not
addressed:
'''rdata_tsig_unittest.cc'''
- multi line case doesn't seem to be tested either (also for others)
'''sshfp_44.cc'''
- [if you switch to this type of pimpl, you'll need to define
`operator=()`; otherwise it would eventually cause duplicate free.]
(check that by writing a test)
For the latter, maybe I was not clear but I intended to suggest adding
a unit test case for assignment. See, e.g., `Rdata_HINFO_Test.copy`.
On a related matter, it would be helpful if you could cite the
list of comments, adding your response to them one by one (maybe
excluding too obvious one like trivial typo). That way it'll be
easier to be sure everything was addressed or to find any missing
points.
> New proposed changelog entry:
This one looks okay.
--
Ticket URL: <http://bind10.isc.org/ticket/2522#comment:20>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list