BIND 10 #2522: support generic version of rdata::createRdata(text) in RP, MINFO, TSIG RDATA

[BIND 10 Development]

#2522: support generic version of rdata::createRdata(text) in RP, MINFO, TSIG
RDATA
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130528
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by pselkirk):

 * owner:  pselkirk => jinmei


Comment:

 Replying to [comment:20 jinmei]:

 > '''rdata_tsig_unittest.cc'''
 >
 > - multi line case doesn't seem to be tested either (also for others)

 I've only been adding multi-line tests for rdata types with terminal key-
 data fields where spaces are allowed in the key data (dhcid, rrsig,
 sshfp), in order to test multi-line keys.

 RFC2845 doesn't specify a presentation format, so we've defined the data
 fields as base-64 with no spaces (or line breaks, as I tested it out). It
 appears that BIND 9 also doesn't allow whitespace of any sort in the MAC
 and Other Data fields.

 In any case, I added a test for multi-line ordinary data, which could be
 done for any rdata type with multiple fields. Is this what you mean by
 "also for others" - that all rdata unit tests should have a multi-line
 test?

 > '''sshfp_44.cc'''
 > - [if you switch to this type of pimpl, you'll need to define
 >   `operator=()`; otherwise it would eventually cause duplicate free.]
 >   (check that by writing a test)
 >
 > For the latter, maybe I was not clear but I intended to suggest adding
 > a unit test case for assignment.  See, e.g., `Rdata_HINFO_Test.copy`.

 Added. My oversight.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2522#comment:22>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development