BIND 10 #2522: support generic version of rdata::createRdata(text) in RP, MINFO, TSIG RDATA

BIND 10 Development do-not-reply at isc.org
Mon May 27 03:33:43 UTC 2013


#2522: support generic version of rdata::createRdata(text) in RP, MINFO, TSIG
RDATA
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  pselkirk
            Priority:  medium        |                       Status:
           Component:  libdns++      |  closed
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130528
         Sub-Project:  DNS           |                   Resolution:  fixed
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  4.5           |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by pselkirk):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 Merged to master in commit ea97070cf6b41299351fc29af66fa39c6465d56a:

 {{{
 * 64bc088 [2522] revised "copy" test for SSHFP: make sure to use
 assignment, not copy.
 * 8ed9ddf [2522] minor style matter: brace position
 * e08a21c [2522] a couple more TSIG and SSHFP unit tests
 * 7e0b47d [2522] TSIG documentation, TSIG unit test string constructors
 * 87a710d [2522] support multiline or space-separated fingerprint text in
 SSHFP
 * 7acdd8d [2522] remove OldRdataFactory, make AbstractRdataFactory pure
 virtual
 * c39edd2 [2522] add SSHFP::operator=
 * a2b82fc [2522] style fix: folded long lines
 * 0b2800a [2522] updated 'missing origin' tests so we test all names
 * ea07789 [2522] avoid initializing std::string at a namescope level to
 avoid fiasco.
 * 1e1f87c [2522] style fix: adjusted brace positions
 * 16ad2c5 [2522] rewrite TSIG string constructor documentation
 * 29b82a6 [2522] add some SSHFP negative-value unit tests
 * dc25eef [2522] MINFO & RP review updates
 * fcca4e8 [2522] TSIG review updates
 * 592db04 [2522] more and better SSHFP unit tests
 * c7e3803 [2522] convert SSHFP to use Impl struct
 * 8cb0a56 [2522] add MasterLexer constructors for in::SSHFP, ch::A, hs::A.
 * b48e4ef Merge branch 'trac2522' of
 ssh://git.bind10.isc.org/var/bind10/git/bind10 into trac2522
 * ab579f5 [2522] some simple suggested fixes:
 * 943f4ea [2522] trivial style fix
 * ef6d944 [2522] minor style fixes
 * 9eab415 [2522] trivial style cleanup: folded long lines
 * a2500cf [2522] fix a typo
 * da4f84b [2522] initialize impl_ directly in TSIG lexer constructor
 * adc3e2f [2522] TSIG algorigthm can be a reference, maybe a bit more
 efficient
 * 60c3b44 [2522] convert TSIG string constructor tests to checkFromText
 * dc4cf0c [2522] more TSIG unit tests
 * 1a39094 [2522] add MasterLexer constructor for TSIG
 * c8aff6a [2522] fix RP unit test
 * 320f10a [2522] more MINFO unit tests
 * 323d64c [2522] add MasterLexer constructor for MINFO
 * 2b5052e [2522] normalize some RP documentation comments
 * 3d23487 [2522] add MasterLexer constructor for RP
 }}}

 Resolving as fixed. Many thanks to Jinmei for the reviews.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2522#comment:26>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list