BIND 10 #2796: Add a counter for queries with RD=1

[BIND 10 Development]

#2796: Add a counter for queries with RD=1
-------------------------------------+-------------------------------------
            Reporter:  y-aharen      |                        Owner:
                Type:  enhancement   |  UnAssigned
            Priority:  medium        |                       Status:
           Component:  b10-auth      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130611
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 '''!ChangeLog'''

 - I'd at least explain what this counter means.

 '''general'''

 - Is there a reason for limiting this counter for queries?

 '''statistics.cc.pre'''

 - (If there's a reason for the limitation) I'd compare opcode as an
   Opcode object.  It should be much better than using a magic number:
 {{{#!cpp
         if (code == 0) {
 }}}

 '''statistics.h'''

 - param name in doxygen is incorrect:
 {{{#!cpp
     /// \param with_dnssec_ok true if Recursion Desired (RD)bit of the
 request
     //                        is set
     /// \throw None
     void setRequestRD(const bool with_rd) {
         bit_attributes_[REQ_WITH_RD] = with_rd;
     }
 }}}

 '''lettuce features'''

 - What's the purpose of removing these?  They don't seem to be related
   to this branch:
 {{{#!diff
 -        # make sure Auth module replied to the command
 -        And wait for new bind10 stderr message CC_REPLY
 -        # make sure the response is for 'getstats'
 -        And wait for new bind10 stderr message v4
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/2796#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development