BIND 10 #2796: Add a counter for queries with RD=1

[BIND 10 Development]

#2796: Add a counter for queries with RD=1
-------------------------------------+-------------------------------------
            Reporter:  y-aharen      |                        Owner:
                Type:  enhancement   |  jinmei
            Priority:  medium        |                       Status:
           Component:  b10-auth      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130611
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by y-aharen):

 * owner:  y-aharen => jinmei


Comment:

 Hello,

 Thank you for reviewing.

 Replying to [comment:6 jinmei]:
 > '''!ChangeLog'''
 >
 > - I'd at least explain what this counter means.
 I added an explanation (git 1ad0a17).

 > '''general'''
 >
 > - Is there a reason for limiting this counter for queries?
 Yes. To monitor an authoritative server, I think it is interesting
 to count 'queries' with RD=1. They are "recursive queries": normally
 they will not be reached to authoritative servers.

 > '''statistics.cc.pre'''
 >
 > - (If there's a reason for the limitation) I'd compare opcode as an
 >   Opcode object.  It should be much better than using a magic number:
 > {{{#!cpp
 >         if (code == 0) {
 > }}}
 I updated the code to use a constant instead of a magic number (git
 89b1ca9).
 I didn't use the Opcode object to reuse a numeric code; if it's not good,
 I'll update the code as you suggested.

 > '''statistics.h'''
 >
 > - param name in doxygen is incorrect:
 > {{{#!cpp
 >     /// \param with_dnssec_ok true if Recursion Desired (RD)bit of the
 request
 >     //                        is set
 >     /// \throw None
 >     void setRequestRD(const bool with_rd) {
 >         bit_attributes_[REQ_WITH_RD] = with_rd;
 >     }
 > }}}
 I corrected it (git d3a4dc9).

 > '''lettuce features'''
 >
 > - What's the purpose of removing these?  They don't seem to be related
 >   to this branch:
 > {{{#!diff
 > -        # make sure Auth module replied to the command
 > -        And wait for new bind10 stderr message CC_REPLY
 > -        # make sure the response is for 'getstats'
 > -        And wait for new bind10 stderr message v4
 > }}}
 I've noticed they are not needed with #1938. For occasional test failures
 in the past, I thought it's because there were no checks for the response
 to
 'getstats' (and I added them). However, the real cause of the failures are
 an
 unpredictable behaviour of "only_new". These four lines made the test
 stable
 as a side effect, but they're not necessary with #1938.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2796#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development