BIND 10 #2907: add ConfigurableClientList::getZoneTableAccessor method

[BIND 10 Development]

#2907: add ConfigurableClientList::getZoneTableAccessor method
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  vorner
            Priority:  medium        |                       Status:
           Component:  data source   |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130611
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  3             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  shared memory data source
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by pselkirk):

 * owner:  pselkirk => vorner


Comment:

 Replying to [comment:14 vorner]:

 > > > Also, as shared_ptr is not a primitive type, it may be better to
 pass it as `const shared_ptr<...> &` (reference), so the counter is not
 incremented and decremented needlessly.

 Okay, I changed it in the unit test, where we're actually passing it to
 the validation function.

 > This is more readable now. However, the special-case for `numZones == 0`
 is not necessary and will follow of the basic loop naturally.

 Okay, tightened.

 > Also, while Jinmei's „yes“ to the first question is ambiguous, I believe
 it was for the second option, to add an abstract method to the base class.

 Added, although I then had to update `SingletonList` in
 src/bin/auth/tests/query_unittest.cc (the only other class derived from
 `ClientList`).

 > So, is the zone table accessor needed only when configuring it, or is it
 needed during general server handling?

 This is the crucial question, isn't it? I can only guess at intent.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2907#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development