BIND 10 #2940: DHCPv4 server crashes when using Memfile backend and running perfdhcp

[BIND 10 Development]

#2940: DHCPv4 server crashes when using Memfile backend and running perfdhcp
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:
                Type:  defect        |  marcin
            Priority:  medium        |                       Status:
           Component:  dhcp4         |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20131016
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:
                                     |  Medium
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by marcin):

 I applied a patch and then made the following extensions to the code:
 - Created the unit tests for Lease4 and moved the unit test which tests
 returning client id as vector to this new file.
 - Extended the !LeaseMgr unit tests to make more extensive use of leases
 with NULL client id.
 - Fixed typos and updated some doxygen comments.

 Proposed !ChangeLog entry:
 {{{
 XXX.    [bug]           dclink,marcin
         libdhcpsrv: Fixed a bug in Memfile lease database backend which
         caused DHCPv4 server crashes when leases with NULL client id
         were present.
         (Trac #2940, git cafebeef)
 }}}

 I am now in the process of system testing this code. Once I confirm that
 the server is not crashing anymore the ticket goes for the further review
 to someone else.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2940#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development