BIND 10 #2940: DHCPv4 server crashes when using Memfile backend and running perfdhcp

[BIND 10 Development]

#2940: DHCPv4 server crashes when using Memfile backend and running perfdhcp
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:
                Type:  defect        |  marcin
            Priority:  medium        |                       Status:
           Component:  dhcp4         |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20131016
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:
                                     |  Medium
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tomek):

 * owner:  tomek => marcin


Comment:

 '''lease.cc'''
 getClientIdVector() returns a copy. This has a potential of making a copy
 of every client-id in the db when we use specific search index. Please
 consider returning a reference.

 '''memfile_lease_mgr.cc'''
 Lines 83 and 127: please add a space after 'if'.

 Would it be possible to modify mutlti-index container to do the same with
 DUIDs as it does with clientIds now? That would eliminate the need to use
 KeyFromKeyExtractor. This is an honest question. No is a perfectly good
 answer here :)

 Please move content of MemfileLeaseMgrTest.{getLease4ClientId,
 getLease4NullClientId, getLease4ClientIdHWAddrSubnetId} to
 GenericLeaseMgrTest. Those tests should be perfectly valid for reuse for
 MySQL (and upcoming PostgreSQL, too).

 I do not have any specific preference how this move is being conducted,
 but it is very important to share those tests among all backends. It will
 be even more important with every backend we add.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2940#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development