BIND 10 #3171: PD: AllocationEngine support for Prefix Delegation, pt.2

[BIND 10 Development]

#3171: PD: AllocationEngine support for Prefix Delegation, pt.2
-------------------------------------+-------------------------------------
            Reporter:  tomek         |                        Owner:
                Type:  enhancement   |  marcin
            Priority:  high          |                       Status:
           Component:  dhcp6         |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20131016
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tomek):

 * owner:  tomek => marcin


Comment:

 Replying to [comment:5 marcin]:
 > I fixed one typo in the doxygen, so please pull these changes.
 Thanks.
 >
 > > >
 > > > Please propose a !ChangeLog entry for this ticket.
 > Please! :-)
 Since you asked so nicely, I just added it :)

 > Sorry. I meant that the !AllocEngine section consists of two paragraphs
 and the first one could be moved to other section. But, treat it
 suggestion. I don't insist.
 Ok. That makes sense. Added new section. We now have 2 very small
 sections, but hopefully they will grow over time.

 >
 > > > '''src/lib/dhcpsrv/subnet.cc'''
 > > > * getPools (variable variant): IMHO, the non-const variant would be
 more appropriate.
 > > I don't get this comment. There are const and non-const variants.
 Depending on the case both are used.
 >
 > Sorry. I wasn't clear enough here. I think the commentary should be
 changed to say:
 > {{{
 >     /// @brief Returns all pools (non-const variant)
 > }}}
 Comment clarified.

 > > C++ purity is not a deliverable on the demo. I can add a @todo to the
 code if you like, but it is unlikely that anyone would implement this
 before November.
 >
 > It is unlikely to be implemented if we put the todo. It is not an
 extensive change. It is actually very simple and I was able to implement
 it locally within 5 minutes when doing this review. See:
 >
 > http://pastebin.com/45R7Ky0C
 I applied that patch, but as we discussed on jabber, it doesn't solve the
 problem completely. It would require defining PoolPtr, ConstPoolPtr,
 Pool4Ptr, ConstPool4Ptr, Pool6Ptr and ConstPool6Ptr and the casting
 between them as needed. I think that applying your proposed change was a
 reasonable compromise.

 I think that addresses all your comments. If you think that the ChangeLog
 commited is ok, the ticket should be ready to merge.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3171#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development