BIND 10 #3191: Kea4: siaddr field must be configurable

[BIND 10 Development]

#3191: Kea4: siaddr field must be configurable
-------------------------------------+-------------------------------------
            Reporter:  tomek         |                        Owner:
                Type:  defect        |  marcin
            Priority:  medium        |                       Status:
           Component:  dhcp4         |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20131016
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tomek):

 * owner:  tomek => marcin


Comment:

 Replying to [comment:4 marcin]:
 > Reviewed commit: e98ccfe63db14be0d9a027797ffd75885b296969
 >
 > '''doc/guide/bind10-guide.xml'''
 > Typo: !''form the TFTP server!''. It should be !''from the TFTP
 server!''.
 Fixed.

 > '''src/bin/dhcp4/config_parser.cc'''
 > Why do you use a raw pointer (subnet4) instead shared_ptr (subnet_) in
 invocations to setSiaddr?
 Updated to Subnet4Ptr. I can't use subnet_ directly, because it is
 SubnetPtr object and setSiaddr() method is available in Subnet4 object
 only, not in Subnet.

 > '''src/bin/dhcp4/dhcp4.spec'''
 > Trivial: Line 229-231 - odd alignment of lines
 Fixed.

 > '''src/bin/dhcp4/tests/config_parser_unittest.cc'''
 > There are no negative tests for the siaddr. If you think it is too much
 burden, please add a todo comment. In particular I am thinking that
 invalid next-server (say abc) should result in configuration failure.
 Added test that checks 3 negatives: garbage (a.b.c.d), IPv6 address and
 empty string.


 > '''src/lib/dhcpsrv/subnet.cc'''
 > setSiaddr: Can you replace !''addr!'' with !''address!'' in the
 exception string.
 > Spurious commentary in lines 163 and 164.
 Removed.

 > '''src/lib/dhcpsrv/subnet.h'''
 > Capital letters are encouraged. :-)
 Capitalized a couple of them. Not sure if there are any left.


 > '''src/lib/dhcpsrv/tests/subnet_unittest.cc'''
 > I think that the description of the siaddr test is misleading. We barely
 check that we can set and get the value of the siaddr. Also typo
 !''handle!''. Should be !''handled!''.
 Description updated.

 > That change deserves a !ChangeLog.
 ChangeLog proposal added.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3191#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development