BIND 10 #3073: [kean] Add empty() method to Element

[BIND 10 Development]

#3073: [kean] Add empty() method to Element
-------------------------------------+-------------------------------------
            Reporter:  muks          |                        Owner:  kean
                Type:  enhancement   |                       Status:
            Priority:  medium        |  reviewing
           Component:                |                    Milestone:
  configuration                      |  Sprint-20131015
            Keywords:                |                   Resolution:
           Sensitive:  0             |                 CVSS Scoring:
         Sub-Project:  DNS           |              Defect Severity:  N/A
Estimated Difficulty:  3             |  Feature Depending on Ticket:
         Total Hours:  0             |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  UnAssigned => kean


Comment:

 Hi Kean

 `make check` fails on this branch. Was it run in your local environment
 before putting the branch to review?

 {{{
 [----------] 36 tests from ListTestMapped/ListTest
 [ RUN      ] ListTestMapped/ListTest.emptyReset/0
 [       OK ] ListTestMapped/ListTest.emptyReset/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.selfTest/0
 [       OK ] ListTestMapped/ListTest.selfTest/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.emptyList/0
 [       OK ] ListTestMapped/ListTest.emptyList/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.emptySearch/0
 [       OK ] ListTestMapped/ListTest.emptySearch/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.singleDSExactMatch/0
 [       OK ] ListTestMapped/ListTest.singleDSExactMatch/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.singleDSBestMatch/0
 [       OK ] ListTestMapped/ListTest.singleDSBestMatch/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.multiExactMatch/0
 [       OK ] ListTestMapped/ListTest.multiExactMatch/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.multiBestMatch/0
 [       OK ] ListTestMapped/ListTest.multiBestMatch/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.configureEmpty/0
 client_list_unittest.cc:512: Failure
 Value of: list_->getConfiguration()
   Actual: 0x1d71a50
 Expected: elem
 Which is: 0x1d7e800
 [  FAILED  ] ListTestMapped/ListTest.configureEmpty/0, where GetParam() =
 0x79a7e8 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.configureMulti/0
 [       OK ] ListTestMapped/ListTest.configureMulti/0 (1 ms)
 [ RUN      ] ListTestMapped/ListTest.configureParams/0
 [       OK ] ListTestMapped/ListTest.configureParams/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.status/0
 [       OK ] ListTestMapped/ListTest.status/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.wrongConfig/0
 client_list_unittest.cc:680: Failure
 Expected: list_->configure(elem, true) throws an exception of type
 ConfigurableClientList::ConfigurationError.
   Actual: it throws a different type.
 Google Test trace:
 client_list_unittest.cc:677: {}
 client_list_unittest.cc:680: Failure
 Expected: list_->configure(elem, true) throws an exception of type
 ConfigurableClientList::ConfigurationError.
   Actual: it throws a different type.
 Google Test trace:
 client_list_unittest.cc:677: true
 client_list_unittest.cc:680: Failure
 Expected: list_->configure(elem, true) throws an exception of type
 ConfigurableClientList::ConfigurationError.
   Actual: it throws a different type.
 Google Test trace:
 client_list_unittest.cc:677: 42
 client_list_unittest.cc:680: Failure
 Expected: list_->configure(elem, true) throws an exception of type
 ConfigurableClientList::ConfigurationError.
   Actual: it throws a different type.
 Google Test trace:
 client_list_unittest.cc:677: null
 [  FAILED  ] ListTestMapped/ListTest.wrongConfig/0, where GetParam() =
 0x79a7e8 (2 ms)
 [ RUN      ] ListTestMapped/ListTest.defaults/0
 [       OK ] ListTestMapped/ListTest.defaults/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.reconfigure/0
 client_list_unittest.cc:704: Failure
 Value of: list_->getDataSources().empty()
   Actual: false
 Expected: true
 [  FAILED  ] ListTestMapped/ListTest.reconfigure/0, where GetParam() =
 0x79a7e8 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.dataSrcError/0
 [       OK ] ListTestMapped/ListTest.dataSrcError/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.dataSrcLibraryError/0
 [       OK ] ListTestMapped/ListTest.dataSrcLibraryError/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.configureCacheEmpty/0
 [       OK ] ListTestMapped/ListTest.configureCacheEmpty/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.configureCacheDisabled/0
 [       OK ] ListTestMapped/ListTest.configureCacheDisabled/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.cacheZones/0
 [       OK ] ListTestMapped/ListTest.cacheZones/0 (1 ms)
 [ RUN      ] ListTestMapped/ListTest.badCache/0
 [       OK ] ListTestMapped/ListTest.badCache/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.cacheInNonWritableSegment/0
 [       OK ] ListTestMapped/ListTest.cacheInNonWritableSegment/0 (1 ms)
 [ RUN      ] ListTestMapped/ListTest.masterFiles/0
 [       OK ] ListTestMapped/ListTest.masterFiles/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.names/0
 [       OK ] ListTestMapped/ListTest.names/0 (2 ms)
 [ RUN      ] ListTestMapped/ListTest.BadMasterFile/0
 [       OK ] ListTestMapped/ListTest.BadMasterFile/0 (2 ms)
 [ RUN      ] ListTestMapped/ListTest.checkZoneWriterCatchesExceptions/0
 [       OK ] ListTestMapped/ListTest.checkZoneWriterCatchesExceptions/0 (1
 ms)
 [ RUN      ] ListTestMapped/ListTest.checkZoneWriterThrows/0
 [       OK ] ListTestMapped/ListTest.checkZoneWriterThrows/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.reloadSuccess/0
 [       OK ] ListTestMapped/ListTest.reloadSuccess/0 (1 ms)
 [ RUN      ] ListTestMapped/ListTest.reloadNotEnabled/0
 [       OK ] ListTestMapped/ListTest.reloadNotEnabled/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.reloadNoSuchZone/0
 [       OK ] ListTestMapped/ListTest.reloadNoSuchZone/0 (1 ms)
 [ RUN      ] ListTestMapped/ListTest.reloadZoneGone/0
 [       OK ] ListTestMapped/ListTest.reloadZoneGone/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.reloadNewZone/0
 [       OK ] ListTestMapped/ListTest.reloadNewZone/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.reloadZoneThrow/0
 [       OK ] ListTestMapped/ListTest.reloadZoneThrow/0 (1 ms)
 [ RUN      ] ListTestMapped/ListTest.reloadNullIterator/0
 [       OK ] ListTestMapped/ListTest.reloadNullIterator/0 (0 ms)
 [ RUN      ] ListTestMapped/ListTest.reloadMasterFile/0
 [       OK ] ListTestMapped/ListTest.reloadMasterFile/0 (11 ms)
 [ RUN      ] ListTestMapped/ListTest.reloadByDataSourceName/0
 [       OK ] ListTestMapped/ListTest.reloadByDataSourceName/0 (1 ms)
 [----------] 36 tests from ListTestMapped/ListTest (27 ms total)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/3073#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development