BIND 10 #433: [kean] run msgq when already running removes socket file

BIND 10 Development do-not-reply at isc.org
Tue Oct 22 08:14:29 UTC 2013


#433: [kean] run msgq when already running removes socket file
-------------------------------------+-------------------------------------
            Reporter:  jreed         |                        Owner:  kean
                Type:  defect        |                       Status:
            Priority:  medium        |  reviewing
           Component:  msgq          |                    Milestone:
            Keywords:                |  Sprint-20131015
           Sensitive:  0             |                   Resolution:
         Sub-Project:  Core          |                 CVSS Scoring:
Estimated Difficulty:  0.0           |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  UnAssigned => kean


Comment:

 Hi Kean

 * Why does `self._existing` need larger scope?

 * When you assign `None` to `self._session`, assuming you mean to destroy
 `self._session`, is there a guarantee in CPython that it is destroyed
 right away during that assignment?

 * In both the log message and the exception that is thrown, please change
 the verbose "message queue daemon" to say "b10-msgq" instead, as it's
 easier for a user to match it to the component.

 * `test_multiple_invocations` should also check that the socket file was
 not deleted at the end of the test, that the existing message queue is
 usable, and as a precondition check that an existing socket file exists.

-- 
Ticket URL: <http://bind10.isc.org/ticket/433#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list