BIND 10 #433: [kean] run msgq when already running removes socket file

[BIND 10 Development]

#433: [kean] run msgq when already running removes socket file
-------------------------------------+-------------------------------------
            Reporter:  jreed         |                        Owner:  kean
                Type:  defect        |                       Status:
            Priority:  medium        |  reviewing
           Component:  msgq          |                    Milestone:
            Keywords:                |  Sprint-20131015
           Sensitive:  0             |                   Resolution:
         Sub-Project:  Core          |                 CVSS Scoring:
Estimated Difficulty:  0.0           |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => kean


Comment:

 Hi Kean

 Replying to [comment:6 kean]:
 > Thanks for the review Muks.
 >
 > I assign self._session to None so that it is in the same state that it
 would have been before the change. It was not intended to have any side
 effects, and I didn't check with CPython because that is not on the list
 of supported platforms or requirements, at least not as documented at
 http://bind10.isc.org/docs/bind10-guide.html#idm65352880.

 CPython is the implementation from python.org that we support by default.
 So please check and answer my original review question.

 > I have reduced the scope of _existing to be local to the condition in
 which it is used.
 >
 > Changed the messages as requested.

 Also please split these up into individual commits as mentioned on Jabber.

 > Added the pre-condition to the test, and check for the socket after the
 test to make sure it exists. There is no need to test that the existing
 queue is usable as the call will fail if a session cannot be started so
 that in itself checks that it is working.

 Have you checked after an attempt to create a second msgq fails, that the
 existing msgq is usable?

-- 
Ticket URL: <http://bind10.isc.org/ticket/433#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development