BIND 10 #3201: Options with no data fields and containing sub options are not parsed correctly

[BIND 10 Development]

#3201: Options with no data fields and containing sub options are not parsed
correctly
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:
                Type:  defect        |  marcin
            Priority:  high          |                       Status:
           Component:  dhcp4         |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20131016
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  High
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tomek):

 * owner:  tomek => marcin


Comment:

 Please update BIND10 guide and add RFC3046 to the list of supported
 RFCs.

 '''libdhcp++_unittest.cc'''
 OPTION_AGENT_CIRCUIT_ID, OPTION_REMOTE_ID, OPTION_VSI,
 OPTION_CMTS_CAPS, OPTION_CM_MAC should be moved to src/lib/dhcp/dhcp4.h
 and
 src/lib/dhcp/docsis3_option_defs.h. The OPTION_CMTS_CAPS and OPTION_CM_MAC
 should
 have some prefix indicating that it is a DOCSIS3 option. In general they
 should
 follow whatever name convention is there in docsis3_option_defs.h.

 '''option_custom_unittest.cc'''
 hasV4Suboption() and hasV6Suboption() may simply return boolean.
 You can report issues with ADD_FAILURE() << "something wrong";
 This is shorter. But if you prefer to keep the AssertionResult, I
 won't object it.

 Changelog should explicitly mention that RAI option is now working
 properly. People may not immediately understand what the changelog
 means. How about:

 {{{
 [bug]           marcin
 libdhcp++: Options with defined suboptions are now handled properly.
 In particular, Relay Agent Info options is now echoed back properly.
 (Trac #3102, git abc)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/3201#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development